fix: use configured customer fixture in webhook address tests - #86
Merged
carolinerg1 merged 1 commit intoAug 14, 2026
Conversation
damaz91
approved these changes
Aug 14, 2026
carolinerg1
approved these changes
Aug 14, 2026
carolinerg1
merged commit Aug 14, 2026
ca74764
into
Universal-Commerce-Protocol:main
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The two webhook address tests hardcoded the flower-shop customer instead of
using the configured fixture:
--fixture_configis a supported conformance input, andDynamicFixtureContext.get_known_customer()already provides the customer amerchant declares. A valid configuration with a different customer would send
the wrong buyer, while a selected non-US destination would be rejected even
when the webhook reproduced it correctly.
Fix: build both buyers from
get_known_customer(), skip the tests when theoptional fixture is absent, and compare the webhook destination with the actual
destination selected from the checkout response rather than a hardcoded
country. The explicit new-address assertions (
CA/Webhook St) remainunchanged.
Category (Required)
Related Issues
N/A
Checklist
generate_models.shunder python_sdk. (Not applicable: conformance test-only change.)Screenshots / Logs (if applicable)
N/A —
webhook_test.pypassed 3/3 against the local Python sample merchant server.ruff check,ruff format --check, full pre-commit, andgit diff --checkalso passed.